-
-
Notifications
You must be signed in to change notification settings - Fork 735
Proposal: Remove in-memory cache for ParseFile #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A great way of doing open-source, 👏🏻. |
@grantland when the release 1.10.4 is planned ? |
@aminelaadhari Unfortunately we don't have an ETA right now for the next release. In addition, the stacktraces from OOM exceptions generally don't point to the root cause of the problem, but are just signals that you have bad memory management somewhere else in your application. It'd be worthwhile to trace your application to see if there is allocation thrashing somewhere. |
Resolved in #116 |
The label |
Right now we keep a in-memory cache for
ParseFile
. Doing this will increaseParseFile
performance in some cases, but it consumes too much memory. This not only downgrades the whole app's performance in some cases but also prevents us from allowing developers to upload/download file that large than 10 MB. After careful consideration and our recent changes toParseFile
related classes (ParseFileController
#73 ,ParseHttpBody
#70 andParseFile
#116). We propose to remove the in-memory cache forParseFile
.Pros:
We do an experiment with uploading and downloading 20 1MB ParseFile, see the memory consumption result
Upload
With in-memory cache
Without in-memory cache
Download


With in-memory cache
Without in-memory cache
Cons:
Please leave your suggestions and feedbacks.
Check PR #116 for details.
The text was updated successfully, but these errors were encountered: