Skip to content

Proposal: Remove in-memory cache for ParseFile #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangmengyan95 opened this issue Sep 9, 2015 · 5 comments
Closed

Proposal: Remove in-memory cache for ParseFile #118

wangmengyan95 opened this issue Sep 9, 2015 · 5 comments
Labels
type:feature New feature or improvement of existing feature
Milestone

Comments

@wangmengyan95
Copy link
Contributor

Right now we keep a in-memory cache for ParseFile. Doing this will increase ParseFile performance in some cases, but it consumes too much memory. This not only downgrades the whole app's performance in some cases but also prevents us from allowing developers to upload/download file that large than 10 MB. After careful consideration and our recent changes to ParseFile related classes (ParseFileController #73 , ParseHttpBody #70 and ParseFile #116). We propose to remove the in-memory cache for ParseFile.

Pros:

  1. Allowing uploading and downloading files that large than 10MB(current limitation)
  2. Much less memory usage
    We do an experiment with uploading and downloading 20 1MB ParseFile, see the memory consumption result
    Upload
    With in-memory cache
    test
    Without in-memory cache
    test

Download
With in-memory cache
test
Without in-memory cache
test

Cons:

  1. Decrease performance since we use in-disk cache instead of in-memory cache

Please leave your suggestions and feedbacks.
Check PR #116 for details.

@wangmengyan95 wangmengyan95 added this to the 1.10.2 milestone Sep 9, 2015
@grantland grantland modified the milestones: 1.10.2, 1.10.3 Sep 10, 2015
@grantland grantland changed the title Remove in-memory cache for ParseFile Proposal: Remove in-memory cache for ParseFile Sep 11, 2015
@faradaj
Copy link

faradaj commented Sep 22, 2015

A great way of doing open-source, 👏🏻.
I think this enhancement has two major aspects:
• Making 'ParseFile-operating apps' smoother.
• Making 'ParseFile-operating apps' respectful to Android.
which are musts for good Android apps.
Seems like a fix rather than an enhancement.
+1

@grantland grantland modified the milestones: 1.10.4, 1.10.3 Oct 6, 2015
@aminelaadhari
Copy link

@grantland when the release 1.10.4 is planned ?
99% of our OOM issues are related to this.

@grantland
Copy link
Contributor

@aminelaadhari Unfortunately we don't have an ETA right now for the next release.

In addition, the stacktraces from OOM exceptions generally don't point to the root cause of the problem, but are just signals that you have bad memory management somewhere else in your application. It'd be worthwhile to trace your application to see if there is allocation thrashing somewhere.

@grantland grantland modified the milestones: 1.11.1, 1.11.0 Nov 11, 2015
@grantland
Copy link
Contributor

Resolved in #116

@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
@parse-github-assistant
Copy link

The label type:feature cannot be used in combination with type:improvement.

@parse-github-assistant parse-github-assistant bot removed the type:feature New feature or improvement of existing feature label Dec 6, 2021
@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

5 participants