Skip to content

Code cleanup #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 19, 2017
Merged

Code cleanup #632

merged 11 commits into from
Apr 19, 2017

Conversation

Jawnnypoo
Copy link
Member

This is mostly just cleanup of lint errors found by Android Studio in the project. I tried to break up the commits by the type of lint error it was, but some commits cover a few things at once

@codecov
Copy link

codecov bot commented Apr 12, 2017

Codecov Report

Merging #632 into master will increase coverage by 0.12%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #632      +/-   ##
============================================
+ Coverage     50.93%   51.05%   +0.12%     
  Complexity     1524     1524              
============================================
  Files           127      127              
  Lines          9727     9699      -28     
  Branches       1313     1310       -3     
============================================
- Hits           4954     4952       -2     
+ Misses         4372     4345      -27     
- Partials        401      402       +1
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/Parse.java 50.46% <ø> (+0.69%) 23 <0> (ø) ⬇️
Parse/src/main/java/com/parse/PushRouter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...se/src/main/java/com/parse/ParseKeyValueCache.java 45% <ø> (-1.54%) 16 <0> (ø)
Parse/src/main/java/com/parse/ParseFileUtils.java 36.58% <0%> (ø) 19 <0> (ø) ⬇️
...rse/src/main/java/com/parse/ParseCommandCache.java 7.18% <0%> (ø) 4 <0> (ø) ⬇️
...se/src/main/java/com/parse/NotificationCompat.java 0% <0%> (ø) 0 <0> (ø) ⬇️
Parse/src/main/java/com/parse/LockSet.java 0% <0%> (ø) 0 <0> (ø) ⬇️
Parse/src/main/java/com/parse/OfflineStore.java 1.43% <0%> (ø) 1 <0> (ø) ⬇️
...arse/src/main/java/com/parse/LocationNotifier.java 0% <0%> (ø) 0 <0> (ø) ⬇️
Parse/src/main/java/com/parse/PushHistory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394851a...16408d2. Read the comment docs.

@Jawnnypoo
Copy link
Member Author

I don't really think there is anything I can do about that first failure on codecov

@flovilmart
Copy link
Contributor

Nah not really, but this is OK, as we don't require the status to merge.

@Jawnnypoo
Copy link
Member Author

@rogerhu Is there something blocking this?

@rogerhu
Copy link
Contributor

rogerhu commented Apr 18, 2017

Nope I think the review required stuff throws me off.

@Jawnnypoo
Copy link
Member Author

Good to merge now, @rogerhu ?

@rogerhu
Copy link
Contributor

rogerhu commented Apr 19, 2017

rebase

@Jawnnypoo
Copy link
Member Author

@rogerhu Done!

@rogerhu rogerhu merged commit 53b05e9 into parse-community:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants