-
-
Notifications
You must be signed in to change notification settings - Fork 735
Code cleanup #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
============================================
+ Coverage 50.93% 51.05% +0.12%
Complexity 1524 1524
============================================
Files 127 127
Lines 9727 9699 -28
Branches 1313 1310 -3
============================================
- Hits 4954 4952 -2
+ Misses 4372 4345 -27
- Partials 401 402 +1
Continue to review full report at Codecov.
|
I don't really think there is anything I can do about that first failure on codecov |
Nah not really, but this is OK, as we don't require the status to merge. |
@rogerhu Is there something blocking this? |
Nope I think the review required stuff throws me off. |
Good to merge now, @rogerhu ? |
rebase |
@rogerhu Done! |
This is mostly just cleanup of lint errors found by Android Studio in the project. I tried to break up the commits by the type of lint error it was, but some commits cover a few things at once