Skip to content

Implementing Parcelable in ParseFile #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2017

Conversation

natario1
Copy link
Contributor

@natario1 natario1 commented Apr 4, 2017

ParseFile Parcelable implementation. With respect to #557 this

  • does not parcel the whole byte array
  • throws if file is not saved
  • safely parcels strings that might be null

@rogerhu
Copy link
Contributor

rogerhu commented Apr 19, 2017

rebase

@codecov
Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #624 into master will increase coverage by 0.11%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #624      +/-   ##
============================================
+ Coverage      52.4%   52.52%   +0.11%     
- Complexity     1647     1659      +12     
============================================
  Files           131      131              
  Lines         10096    10121      +25     
  Branches       1404     1407       +3     
============================================
+ Hits           5291     5316      +25     
- Misses         4364     4365       +1     
+ Partials        441      440       -1
Impacted Files Coverage Δ Complexity Δ
...se/src/main/java/com/parse/ParseParcelEncoder.java 84.37% <100%> (+3.42%) 19 <0> (+1) ⬆️
...se/src/main/java/com/parse/ParseParcelDecoder.java 87.5% <100%> (+0.4%) 29 <0> (+2) ⬆️
Parse/src/main/java/com/parse/ParseFile.java 77.77% <91.3%> (+1.87%) 43 <9> (+9) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf740a...5152369. Read the comment docs.

@natario1
Copy link
Contributor Author

@rogerhu this is ready in my opinion

@rogerhu rogerhu merged commit 46a0233 into parse-community:master Apr 19, 2017
@natario1 natario1 deleted the parcelable-file branch May 1, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants