Parcelable implementation for ParseFile #557
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Is there anyone maintaining this project? |
|
+1 |
|
Can you simply extend the class instead of needing to put in on ParseFile? |
|
Does anyone else have any opinions about the need to do this? |
|
I don’t think that parceling a whole file with its byte array would be considered good practice. I also remember Parcel (or Bundle) throwing when its contents are too large. In my opinion this should work only when the file is backed by an url, and if not (e.g. ParseFile not saved yet) throw an exception. That would be harmless and a good step in the direction of implementing Parcelable in the SDK. |
|
Yeah there is a Parcelable max size of 1 Mb (https://developer.android.com/reference/android/os/TransactionTooLargeException.html) Going to close unless there is a revision to it. |
|
Yes, it seems to be reasonable, the code was updated. |
|
See #122 |
This is the implementation of Parcelable interface on ParseFile for remote and local files. It's very useful to pass complex objects through activities, specially when you are using Parse with delegated properties in Kotlin.