Not allowing setObjectId() in ParseInstallation #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I deal with the issue #607, I found another issue about ParseInstallation.
(It's a very special case, generally should not happen.)
I originally expected another installation data will be created in the server.
But the installation data is
updated
successfully and doesn't return any exceptions.The objectId of cached installation data is also cleared (null).
It seems parser server will refer to 'installationId' when updating the installation data.
In this case, the installation data is not re-created when it is deleted on the server. (will throw Code 135: MissingRequiredFieldError exception)
I think it should be restricted the usage of setObjectId() in ParseInstallation.