Update for OkHttp3 #468
Merged
Update for OkHttp3 #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grantland, @Allsimon and @wangmengyan95 to be potential reviewers. |
ghost
added
|
Looks like there are test failures |
|
@rogerhu updated the pull request. |
|
@rogerhu updated the pull request. |
|
@rogerhu updated the pull request. |
|
Looks great, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to square/okhttp@bab8943 has caused network interceptors to return headers all in lower case because a change in which the toMultimap() function. This change appears to have been added to avoid duplicate headers being sent (https://github.com/square/okhttp/blob/bab8943f2b5c8bc44a64067ada556aa62fcec3a7/okhttp-tests/src/test/java/okhttp3/internal/http/HeadersTest.java#L298-L306).
The downside is that Parse/OkHttp network interceptors exhibit this behavior, but normal interceptors do not. We call the toMultimap() routine that causes headers to be converted to lowercase on downstream requests (see https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseOkHttpClient.java#L187-L189)
I updated the tests to rely on lowercase headers to avoid the test falures. I think the reasoning behind needing toMultiMap() is in case someone needs to rewrite the headers and you want to make sure you are overwriting the right one.