Skip to content

Fix #343: Add proguard consumer file #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016

Conversation

Allsimon
Copy link
Contributor

The Android Gradle plugin allows to define ProGuard rules which get embedded in the AAR. These ProGuard rules are automatically applied when a consumer app sets minifyEnabled to true.

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @grantland and @wangmengyan95 to be potential reviewers.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

-dontwarn android.app.Notification
-dontwarn com.squareup.**
-dontwarn okio.**
#}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline at EOF

@grantland
Copy link
Contributor

This looks great! Please add a the newline at EOF, squash into a single commit, and I can merge this in.

@facebook-github-bot
Copy link

@Allsimon updated the pull request.

grantland added a commit that referenced this pull request Mar 10, 2016
Fix #343: Add proguard consumer file
@grantland grantland merged commit 036b0cb into parse-community:master Mar 10, 2016
@grantland
Copy link
Contributor

Thanks for the contribution!

@facebook-github-bot
Copy link

@Allsimon updated the pull request.

@grantland grantland modified the milestone: 1.13.1 May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants