-
-
Notifications
You must be signed in to change notification settings - Fork 735
Fix #343: Add proguard consumer file #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By analyzing the blame information on this pull request, we identified @grantland and @wangmengyan95 to be potential reviewers. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
-dontwarn android.app.Notification | ||
-dontwarn com.squareup.** | ||
-dontwarn okio.** | ||
#} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline at EOF
This looks great! Please add a the newline at EOF, squash into a single commit, and I can merge this in. |
@Allsimon updated the pull request. |
Fix #343: Add proguard consumer file
Thanks for the contribution! |
@Allsimon updated the pull request. |
The Android Gradle plugin allows to define ProGuard rules which get embedded in the AAR. These ProGuard rules are automatically applied when a consumer app sets minifyEnabled to true.