Skip to content

Conversation

mematthias
Copy link
Contributor

This pull request is a small excerpt from the #289 PR.

Summary

This PR fixes a critical issue in Pkcs11::new that prevented my PKCS#11 library from being loaded correctly. The root cause was the use of MaybeUninit::uninit() in a context where zero-initialized or null-assigned variables were required. This has been resolved by using explicitly null-assigned variables instead.

Changes

  • Fixed bug in Pkcs11::new related to improper initialization, resolving library loading failure

…ll-assigned variables; this resolves an issue that prevented my PKCS#11 library from loading

Signed-off-by: mematthias <[email protected]>
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me!

Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@wiktor-k wiktor-k merged commit 0169642 into parallaxsecond:main Jun 24, 2025
8 checks passed
@middagj
Copy link

middagj commented Sep 9, 2025

When will there be a new version with this fix included?

@Jakuje
Copy link
Collaborator

Jakuje commented Sep 9, 2025

When will there be a new version with this fix included?

First of all, it would be probably better to start a new discussion thread instead of commenting on old issue.

Right now, we have the PKCS#11 3.2 in, but I would prefer to get #307 and #306 before the release. After that, I do not think there is anything else blocking the release.

@middagj
Copy link

middagj commented Sep 9, 2025

First of all, it would be probably better to start a new discussion thread instead of commenting on old issue.

Sure, will do next time. I didn't want to clutter the issues.

@wiktor-k
Copy link
Collaborator

Sure, will do next time. I didn't want to clutter the issues.

FWIW I don't mind necro-bumping old threads here since the amount of noise is low anyway.

For the record @hug-dev does the releases currently and I hope we'll get one after all these smaller things get merged.

@hug-dev
Copy link
Member

hug-dev commented Sep 12, 2025

let's necro-bump 🥳 !!

Happy to do the release after those PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants