Skip to content

Conversation

ionut-arm
Copy link
Member

@ionut-arm ionut-arm commented Feb 21, 2022

This commit makes a few cargo-audit-related changes:

  • updates the lock file with newer, un-yanked versions of
    futures-... crates
  • Updates the cargo audit config file to ignore the
    chrono and time issues.
  • Updates the security policy to lay out our approach to
    handling vulnerability reports.
  • Remove the cryptoauthlib-provider from all-providers
  • Add cross-compilation testing for the TS provider (for aarch64-linux-gnu)

This commit makes a few cargo-audit-related changes:
* updates the lock file with newer, un-yanked versions of
futures-... crates
* Updates the cargo audit config file to ignore the
`chrono` and `time` issues.
* Updates the security policy to lay out our approach to
handling vulnerability reports.

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm added enhancement New feature or request code health Issues concerning overall code quality, safety and best practice labels Feb 21, 2022
@ionut-arm ionut-arm self-assigned this Feb 21, 2022
@ionut-arm ionut-arm changed the title Audit-related updates Updates for Release Candidate 2 Feb 24, 2022
Since the `rust-cryptoauthlib` crate isn't currently maintained,
and given that it seems to have some issues with cross-compilation
for armv7, we're removing the CAL provider from `all-providers`
until we can get it properly built and maintained.

Signed-off-by: Ionut Mihalcea <[email protected]>
Fixing some of the clippy lints introduced in 1.59.0

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm requested a review from a team as a code owner February 28, 2022 12:49
@ionut-arm ionut-arm added this to the Parsec Release 1.0.0 milestone Mar 1, 2022
The TS provider is currently excluded from the cross-compilation tests.
However, `libts` can be cross-compiled for aarch64-linux-gnu targets.
The `trusted-service-provider` feature is added here to
cross-compilation for the appropriate target only.

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm mentioned this pull request Mar 1, 2022
2 tasks
Copy link
Collaborator

@paulhowardarm paulhowardarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that the CAL provider can still be explicitly built as a feature and used as normal, despite the removal from all-providers? That's what it looks like to me, but I want to double check because I don't think we should be deactivating the provider completely in such a significant milestone release.

We should aim to get this back into all-providers ASAP, but I see we have an issue to track that, so that's good.

@ionut-arm
Copy link
Member Author

I am assuming that the CAL provider can still be explicitly built as a feature and used as normal, despite the removal from all-providers?

Yes, I guess one could say that all-providers is the default set of providers we support. We can add it back whenever there's someone maintaining it!

@ionut-arm ionut-arm merged commit 67a22cc into parallaxsecond:main Mar 2, 2022
@ionut-arm ionut-arm deleted the audit-update branch March 2, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Issues concerning overall code quality, safety and best practice enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants