Fix Connection and TCPClient bugs with partial send #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When socket sends data and it only partially sends, we get an error and the amount of data that was sent. We are only supposed to send the rest of the data next time the socket is free but we were sending the whole thing in the Connection server case, and dropping it on the floor in the client case. Note that we didn't have this problem on the receiving side. Added tests to prove the problems, then fixed them. Also note I could refactor this more, but didn't want to introduce more risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When socket sends data and it only partially sends, we get an error and the amount of data that was sent.
We are only supposed to send the rest of the data next time the socket is free but we were sending the whole thing in the Connection server case, and dropping it on the floor in the client case.
Note that we didn't have this problem on the receiving side.
Added tests to prove the problems, then fixed them.
Also note I could refactor this more, but didn't want to introduce more risk.