Skip to content

ENH Make year and quarter dash-separatable #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/source/whatsnew/v0.16.1.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ API changes
Enhancements
~~~~~~~~~~~~

- Add support for separating years and quarters using dashes, for
example 2014-Q1. (:issue:`9688`)

.. _whatsnew_0161.performance:

Performance Improvements
Expand Down
35 changes: 28 additions & 7 deletions pandas/tseries/tests/test_offsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from pandas import Series
from pandas.tseries.frequencies import _offset_map
from pandas.tseries.index import _to_m8, DatetimeIndex, _daterange_cache, date_range
from pandas.tseries.tools import parse_time_string
from pandas.tseries.tools import parse_time_string, DateParseError
import pandas.tseries.offsets as offsets

from pandas.io.pickle import read_pickle
Expand Down Expand Up @@ -3010,12 +3010,33 @@ def test_get_offset():
(name, expected, offset))


def test_parse_time_string():
(date, parsed, reso) = parse_time_string('4Q1984')
(date_lower, parsed_lower, reso_lower) = parse_time_string('4q1984')
assert date == date_lower
assert parsed == parsed_lower
assert reso == reso_lower
class TestParseTimeString(tm.TestCase):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number as a comment here

def test_parse_time_string(self):
(date, parsed, reso) = parse_time_string('4Q1984')
(date_lower, parsed_lower, reso_lower) = parse_time_string('4q1984')
self.assertEqual(date, date_lower)
self.assertEqual(parsed, parsed_lower)
self.assertEqual(reso, reso_lower)

def test_parse_time_quarter_w_dash(self):
# https://github.com/pydata/pandas/issue/9688
pairs = [
('1988-Q2', '1988Q2'),
('2Q-1988', '2Q1988'),
]

for dashed, normal in pairs:
(date_dash, parsed_dash, reso_dash) = parse_time_string(dashed)
(date, parsed, reso) = parse_time_string(normal)

self.assertEqual(date_dash, date)
self.assertEqual(parsed_dash, parsed)
self.assertEqual(reso_dash, reso)

self.assertRaises(DateParseError, parse_time_string, "-2Q1992")
self.assertRaises(DateParseError, parse_time_string, "2-Q1992")
self.assertRaises(DateParseError, parse_time_string, "4-4Q1992")


def test_get_standard_freq():
Expand Down
16 changes: 8 additions & 8 deletions pandas/tseries/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ def calc_with_mask(carg,mask):
return None

# patterns for quarters like '4Q2005', '05Q1'
qpat1full = re.compile(r'(\d)Q(\d\d\d\d)')
qpat2full = re.compile(r'(\d\d\d\d)Q(\d)')
qpat1 = re.compile(r'(\d)Q(\d\d)')
qpat2 = re.compile(r'(\d\d)Q(\d)')
qpat1full = re.compile(r'(\d)Q-?(\d\d\d\d)')
qpat2full = re.compile(r'(\d\d\d\d)-?Q(\d)')
qpat1 = re.compile(r'(\d)Q-?(\d\d)')
qpat2 = re.compile(r'(\d\d)-?Q(\d)')
ypat = re.compile(r'(\d\d\d\d)$')
has_time = re.compile('(.+)([\s]|T)+(.+)')

Expand Down Expand Up @@ -424,18 +424,18 @@ def parse_time_string(arg, freq=None, dayfirst=None, yearfirst=None):
second=0, microsecond=0)

# special handling for possibilities eg, 2Q2005, 2Q05, 2005Q1, 05Q1
if len(arg) in [4, 6]:
if len(arg) in [4, 5, 6, 7]:
m = ypat.match(arg)
if m:
ret = default.replace(year=int(m.group(1)))
return ret, ret, 'year'

add_century = False
if len(arg) == 4:
if len(arg) > 5:
qpats = [(qpat1full, 1), (qpat2full, 0)]
else:
add_century = True
qpats = [(qpat1, 1), (qpat2, 0)]
else:
qpats = [(qpat1full, 1), (qpat2full, 0)]

for pat, yfirst in qpats:
qparse = pat.match(arg)
Expand Down