ENH Make year and quarter dash-separatable #9701
Conversation
| @@ -3018,6 +3018,21 @@ def test_parse_time_string(): | |||
| assert reso == reso_lower | |||
|
|
|||
|
|
|||
| def test_parse_time_quarter_w_dash(): | |||
| pairs = [ | |||
There was a problem hiding this comment.
add the issue in a comment here
There was a problem hiding this comment.
are there possibilities that it shouldn't match?
|
@jreback I think I've adjusted them accordingly, although I'm not quite sure about the how you want the test-case class. Anyhow, tell me if it looks OK so I can rebase it :) |
| assert parsed == parsed_lower | ||
| assert reso == reso_lower | ||
| class TestParseTimeString(tm.TestCase): | ||
|
|
There was a problem hiding this comment.
add the issue number as a comment here
|
minor comments, pls squash as well. thanks. ping when green. |
This closes pandas-dev#9688 by making years and quarters separable by dashes.
williamhogman
force-pushed
the
feature-dashed-quarters
branch
from
c620a51 to
91c63a6
Compare
|
@jreback That should do it, commits are now squashed. |
ENH Make year and quarter dash-separatable
|
thank you! |
|
Happy to help, pandas has saved my ass too many times to count. William Rudenmalm On Thu, Mar 26, 2015 at 10:50 AM, jreback [email protected] wrote:
|
This closes #9688 by making years and quarters separable by dashes.