-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Gh9010 yahoo options parsing bug #9024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3334c61
BUG: GH9010: fix for Yahoo Options parse error
PollyP e38c7e8
BUG: GH9010 updated Changelog with bug fix info
PollyP 4956c0a
BUG: GH9010: Add a _get_underlying_price test to Yahoo Options
PollyP b461ae2
performance improvement on BUG GH9010
PollyP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -698,8 +698,19 @@ def _option_frames_from_url(self, url): | |
|
||
def _get_underlying_price(self, url): | ||
root = self._parse_url(url) | ||
underlying_price = float(root.xpath('.//*[@class="time_rtq_ticker Fz-30 Fw-b"]')[0]\ | ||
.getchildren()[0].text) | ||
|
||
underlying_price = root.xpath('.//*[@class="time_rtq_ticker Fz-30 Fw-b"]')[0]\ | ||
.getchildren()[0].text | ||
try: | ||
underlying_price = float(underlying_price) | ||
except ValueError: | ||
# see if there is a comma thousands separator in here that needs to be filtered out | ||
# filtering via join works in both Python 2.7 and Python 3 | ||
underlying_price = ''.join(c for c in underlying_price if c != ',') | ||
try: | ||
underlying_price = float(underlying_price) | ||
except ValueError: | ||
underlying_price = np.nan | ||
|
||
#Gets the time of the quote, note this is actually the time of the underlying price. | ||
try: | ||
|
@@ -1192,6 +1203,7 @@ def _process_data(self, frame, type): | |
frame["Quote_Time"] = np.nan | ||
frame.rename(columns={'Open Int': 'Open_Int'}, inplace=True) | ||
frame['Type'] = type | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is simpler
|
||
frame.set_index(['Strike', 'Expiry', 'Type', 'Symbol'], inplace=True) | ||
|
||
return frame |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this needs 1 more space to format properly