BUG: Implement step in slice StringMethod #8843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -674,6 +674,7 @@ def str_slice(arr, start=None, stop=None, step=1): | |||
| ---------- | |||
| start : int or None | |||
| stop : int or None | |||
| step : int or None | |||
There was a problem hiding this comment.
maybe int, default 1 instead?
Or actually, the default could also be just None for step. That is the same as 1 and seems more consistent?
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 18, 2014
BUG: Implement step in slice StringMethod
|
Yeps, indeed dead simple :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8754.
Turned out to be dead simple too :)