Pass figsize into _grouped_plot -- please review #651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atm figsize is not passed through by boxplot etc, making it (impossible?) to have custom figsize
not sure if that was intentional to swallow all those, so if it was -- please at least pass through figsize
|
Thanks. I also pulled in the pyplot.subplots function to improve compatibility with earlier versions of matplotlib. you'll want to reset to upstream/master (since you did pull request from master) but since you're a git guru you probably already know that ;) |
|
THANKS! yeah -- I hope to figure my ways around -- thanks for the note ;) |
|
I think you have missed to adopt 8378545 which took care about passing figsize from DataFrame.boxplot into plots.boxplot (actually it just was to pass whole **kwd) |
|
Oops. Thanks |
dan-nadler
pushed a commit
to dan-nadler/pandas
that referenced
this pull request
Sep 23, 2019
* initial commit for fw pointers implementation * Finalized implementation of forward pointers * incorporated PR comments for fw pointers implementation * fw pointers: chunks_ids to chunk_ids * fix for forward pointers implementation to be robust over mongo_retry with only subset of segments written * minor fix for initialization of ARCTIC_FORWARD_POINTERS * added implementation of cleanup/pruning supporting forward pointers and being also backwards compatible * updated FW pointers implementation to allow any transition from/to ENABLED/DISABLED/HYBRID per write/append/read * added comments explaining forward pointers variables and methods * added check for number of gathered segments when updating fw pointers, and raise operation errors upon failure * forward pointers implementation with SHAs instead of IDs * completed fully functional implementation of SHA based forward pointers * pruning compatible with forward pointers enabled/disabled/hybrid * don't strip() twice in version str * remove unnecessary import * set back the pruning timeout to 120 * set back the pruning timeout to 120 * added numerical value of the arctic version used to crate a version, in the version metadata * fixed index check integration test * fixed multiple bugs with concat_and_write, corrected the pruning and fixed multiple tests after enabling for all VersionStore tests to run in all three modes for forward pointers * fixed all integration tests for versionstore and fixed bug with pruning with FW pointers too early, as the version is not inserted yet when pruning happens * fixed the last two broken integration tests * fix the cleanup logic for forward pointers to retain the chunks created in the past than 24h. Added fw pointers in multiple other tests to verify functionality * moved back in original order the publsh_changes and prune calls * fixed python 3 compatiblility issue with pruning * updated changelog * fixed Binary(b'aaa') != b'aaa' in Python 3 * fixed last remaining failed tests for python 3 related to bson.binary.Binray comparison with binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To still allow default matplotlib size for the figure I added handling of figsize="default"... may be altogether it should just drop custom default size here?
also another commit on **kwds -- depends on what was intended, but at least figsize should be passed