STY: Use strict arg in zip() in pandas/tests/extension #63294
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added strict=True parameter to 11 zip() calls across 7 files in the pandas/tests/extension directory to enforce Ruff rule B905. This ensures that all zipped iterables have equal lengths, making the tests more robust and catching potential bugs early during testing. Files modified: - base/methods.py: 3 zip() calls - date/array.py: 1 zip() call - decimal/array.py: 1 zip() call - json/array.py: 3 zip() calls - test_arrow.py: 1 zip() call - test_categorical.py: 1 zip() call - test_interval.py: 1 zip() call
I changed two zip() calls in json/array.py from strict=True to strict=False because the 'value' variable can be an itertools.cycle() iterator (line 145), which is infinite. You cannot use strict=True with infinite iterators as they don't have a defined length to compare. Lines changed: - Line 149: enumerate(zip(key, value, strict=False)) - Line 154: zip(key, value, strict=False)
I broke long lines into multiple lines to comply with the 88-character line length limit enforced by ruff. Files fixed: - base/methods.py:353 - Split list comprehension with zip across multiple lines - test_interval.py:37 - Split list comprehension with zip across multiple lines This addresses the pre-commit.ci E501 failures.
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
strict=Trueparameter to 11zip()calls across 7 files in thepandas/tests/extensiondirectory to enforce Ruff rule B905.Changes made:
base/methods.py: 3 zip() calls (lines 353, 372, 630)date/array.py: 1 zip() call (line 165)decimal/array.py: 1 zip() call (line 298)json/array.py: 3 zip() calls (lines 131, 149, 154)test_arrow.py: 1 zip() call (line 285)test_categorical.py: 1 zip() call (line 129)test_interval.py: 1 zip() call (line 37)This ensures that all zipped iterables have equal lengths, making the tests more robust and catching potential bugs early during testing.
Checklist:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature - N/A: Style fix doesn't require whatsnew entryAGENTS.md- N/A: Manual code changes