CI/TST: fix tests for compat with numpy 2+ when using legacy promotion #60140
Conversation
jorisvandenbossche
added
CI
|
This does not yet fix the macos and arm failure (those are also failing on main, and separate issues) |
-> #60143 |
Saw this randomly. Is that hard? I mean, I think you can just remove any setting of (I was planning to remove support for it in 2.2, I thought I already did in the nightlies, but maybe not.) |
|
No idea, let's see in #60144 (I was planning to open an issue about it, because in addition to CI I think there is also the discussion about "following" the new behaviour of numpy) |
|
Well, FYI, I was planning to remove this in NumPy 2.2. I would have guessed that I already did in the nightlies... |
Yeah, we already ran into |
|
In any case, it seems to be working fine to completely remove the usage of the env variable -> #60144 |
|
Closing this in favor of #60144 |
This is trying to fix the current failures on main.
It seems that our test runs were still using numpy 1.26 (because of some downgrade after initial env creation because of removing nomkl), but that stopped being the case some hours ago. This turns up a bunch of failures in our tests when running hem with numpy >= 2 ánd with
NPY_PROMOTION_STATE=legacy.We should properly fix this situation (stop using the legacy promotion state), but this PR should already get CI green again.