REF: Prefer testing and documenting zoneinfo instead of pytz #59016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
WillAyd
reviewed
Jun 21, 2024
|
|
||
| pandas provides rich support for working with timestamps in different time | ||
| zones using the ``pytz`` and ``dateutil`` libraries or :class:`datetime.timezone` | ||
| zones using the ``zoneinfo``, ``pytz`` and ``dateutil`` libraries or :class:`datetime.timezone` |
Member
There was a problem hiding this comment.
Do we even really need to advertise pytz any more or can it be fully replaced by zoneinfo?
Member
Author
There was a problem hiding this comment.
I think zoneinfo objects support all operations that pytz does. I was planning on keeping it around since it will be supported via an optional dependency I suppose.
If we ever deprecate pytz support, I would fully support not advertising it anymore
Member
Author
|
Going to merge this PR to make progress on #57045, happy to follow up if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #57045
zoneinfo.ZoneInfoobjects being acceptedpytz.utc->datetime.timezone.utc,pytz.timezone("US/Pacific")->zoneinfo.ZoneInfo("US/Pacific")