Skip to content

STYLE: Detect unnecessary pylint ignore #57918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

STYLE: Detect unnecessary pylint ignore #57918

merged 1 commit into from
Mar 19, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 19, 2024

Enable pylint's I0021/useless-suppression (doc)

This should make it easier to recognize how many pylint rules that ruff is still missing.

@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Mar 19, 2024
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 19, 2024
MarcoGorelli
MarcoGorelli approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tqa236

@MarcoGorelli MarcoGorelli merged commit 495f808 into pandas-dev:main Mar 19, 2024
@tqa236 tqa236 deleted the detect-unnecessary-pylint-ignore branch March 19, 2024 22:27
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tqa236 @pmhatre1
STYLE: Detect unnecessary pylint ignore (pandas-dev#57918)
0196bbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tqa236 @MarcoGorelli