Skip to content

CLN: Enforce deprecation of method and limit in pct_change methods #57742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2024
Merged

CLN: Enforce deprecation of method and limit in pct_change methods #57742

merged 3 commits into from
Mar 6, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Ref: #53520

@rhshadrach rhshadrach added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Clean Transformations e.g. cumsum, diff, rank labels Mar 6, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Mar 6, 2024
@mroeschke mroeschke merged commit b89b2f1 into pandas-dev:main Mar 6, 2024
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the cln_pct_change_fill branch March 7, 2024 00:00
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@rhshadrach @pmhatre1
CLN: Enforce deprecation of method and limit in pct_change methods (p…
9bfbe07 
…andas-dev#57742)

* CLN: Enforce deprecation of method and limit in pct_change methods

* Test fixups

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Transformations e.g. cumsum, diff, rank
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke