Fix numpy-dev CI warnings #57379
Merged
Fix numpy-dev CI warnings #57379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Feb 12, 2024
| "NpyArr_iterNextItem received a non-array object"); | ||
| return 0; | ||
| } | ||
| PyArrayObject *arrayobj = (PyArrayObject *)npyarr->array; |
There was a problem hiding this comment.
This is the only instance in our JSON code where we could not use a const qualifier for the PyArrayObject type because PyArray_DESCR accepts a non-const type. I think this is something that will eventually be addressed in numpy/numpy#24855 (comment) but @seberg probably knows more
There was a problem hiding this comment.
Yeah, I noticed that problem as well today. I think we should change it, might annoy some C++ folks, but should be easy enough to work around.
WillAyd
added
CI
mroeschke
approved these changes
Feb 12, 2024
|
Thanks @WillAyd |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 12, 2024
mroeschke
pushed a commit
that referenced
this pull request
Feb 12, 2024
Backport PR #57379: Fix numpy-dev CI warnings Co-authored-by: William Ayd <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.