Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 17, 2013

Still working on the 140 char version. maybe we should just use the sha1 instead. hmm.

ghost pushed a commit that referenced this pull request Dec 17, 2013
@ghost ghost merged commit 5d6bbe8 into pandas-dev:master Dec 17, 2013
@ghost ghost deleted the PR_contributing branch December 17, 2013 15:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't (necessarily) need this anymore, every PR to pydata/pandas should cause Travis to build automatically.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall at least one PR submitted after that change which didn't have
a travis build attached to it. Have you explicitly tested that it works? if yes, let's drop the
travis hand-holding sections altogether.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm convinced, I pushed another commit to remove it all.

@shoyer shoyer mentioned this pull request Aug 20, 2021
4 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant