BUG: to_stata not handling ea dtypes correctly #56771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
IO Stata
jbrockmendel
reviewed
Jan 7, 2024
pandas/io/stata.py
Outdated
| @@ -591,17 +591,21 @@ def _cast_to_stata_types(data: DataFrame) -> DataFrame: | |||
|
|
|||
| for col in data: | |||
| # Cast from unsupported types to supported types | |||
| is_nullable_int = isinstance(data[col].dtype, (IntegerDtype, BooleanDtype)) | |||
| is_nullable_int = ( | |||
| is_extension_array_dtype(data[col].dtype) and data[col].dtype.kind in "iub" | |||
There was a problem hiding this comment.
Just check isinstance ExtensionDtype
mroeschke
approved these changes
Jan 8, 2024
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 8, 2024
mroeschke
pushed a commit
that referenced
this pull request
Jan 8, 2024
…pes correctly) (#56783) Backport PR #56771: BUG: to_stata not handling ea dtypes correctly Co-authored-by: Patrick Hoefler <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* BUG: to_stata not handling ea dtypes correctly * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.