Skip to content

BUG: merge not raising for String and numeric merges #56441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 10, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Strings String extension data type and string data labels Dec 10, 2023
@phofl phofl added this to the 2.2 milestone Dec 10, 2023
@phofl phofl requested a review from mroeschke December 15, 2023 22:46
@mroeschke mroeschke merged commit 3fdf0d3 into pandas-dev:main Dec 18, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the merge_raise_string branch December 18, 2023 19:58
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
* BUG: merge not raising for String and numeric merges

* Add coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants