DEPR: kind keyword in resample #55895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Resample
Member
|
Was there an existing issue discussing this too? |
Member
Author
|
no |
WillAyd
reviewed
Nov 14, 2023
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
I am on board with this - I don't think this keyword offers any value over the suggested approach
| def test_to_excel_periodindex(self, tsframe, path): | ||
| xp = tsframe.resample("ME", kind="period").mean() | ||
| # xp has a PeriodIndex | ||
| xp = tsframe.resample("ME").mean().to_period("M") |
Member
There was a problem hiding this comment.
Does it matter at all that the order of operations here change? Before the conversion to period happened before the mean() call - wonder if there are differences in how those objects implement mean that could cause rounding issues or behavior changes
Member
Author
There was a problem hiding this comment.
i think the only thing we care about is the xp we get here, since we are checking that it round-trips. i checked manually that this is equivalent to what we have in main
mroeschke
approved these changes
Nov 30, 2023
Member
|
Thanks @jbrockmendel |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Feb 8, 2024
For comparison: pandas-dev/pandas#55856 pandas-dev/pandas#55895 pandas-dev/pandas#55499 The `errors="ignore"` parameter is the only one that is implemented so just added a test for that deprecation Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #14984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.