CLN: Remove None check in attrs property lookup #54364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be a good change for this PR |
timhoffm
force-pushed
the
attrs-property
branch
from
d87c072 to
21eec4f
Compare
`self._attrs` is always initialized to an empty dict per https://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L275 The attribute `_attrs` is only witten to in two other places a) in the attrs.setter property (which enforces dict as well) b) in __setstate__, which takes whatever the state is: https://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L2129C24-L2129C24 AFAICS (including code history) I do not see a reason that this could be None. But if we want to be very defensive, we should do the dict enforcing here.
timhoffm
force-pushed
the
attrs-property
branch
from
21eec4f to
7abba38
Compare
|
I've now included the dict-enforcement in |
mroeschke
approved these changes
Aug 2, 2023
|
Thanks @timhoffm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self._attrsis always initialized to an empty dict perpandas/pandas/core/generic.py
Line 275 in c93e803
The attribute
_attrsis only witten to in two other placesa) in the attrs.setter property (which enforces dict as well)
b) in
__setstate__, which takes whatever the state is:pandas/pandas/core/generic.py
Line 2129 in c93e803
AFAICS (including code history) I do not see a reason that this could be None.
But if we wanted to be very defensive, we should do the dict enforcing here.