REF: helpers to de-duplicate CoW checks #53882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Jun 27, 2023
|
Thanks @jbrockmendel |
phofl
reviewed
Jun 28, 2023
| def _maybe_copy(self, using_cow: bool, inplace: bool) -> Self: | ||
| if using_cow and inplace: | ||
| deep = self.refs.has_reference() | ||
| blk = self.copy(deep=deep) |
There was a problem hiding this comment.
Just a general note here (it's not a problem right now): this could have side effects, creating a shallow copy of the block sets up another reference, which will yield True for blk.refs.has_reference() and self.refs.has_reference(), so have to be a bit careful when using
|
Thx for cleaning this up! |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* REF: refactor out Block helpers for CoW * REF: de-duplicate helpers * De-duplicate helper, revert _replace_coerce edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Can do a little bit more along these lines, but am splitting it into smaller chunks bc the refactored helpers are not perfect cut/paste.