Skip to content

CLN: use lib.no_default instead of lib.NoDefault in .pivot #53877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2023
Merged

CLN: use lib.no_default instead of lib.NoDefault in .pivot #53877

merged 4 commits into from
Jun 27, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Jun 27, 2023 •
edited
Loading

@mroeschke mroeschke added this to the 2.1 milestone Jun 27, 2023
@mroeschke mroeschke merged commit a3ab7a3 into pandas-dev:main Jun 27, 2023
@mroeschke
Copy link
Member

Nice one thanks @Charlie-XIAO (if you can think of a linting check to ensure lib.NoDefault is only used for typing, that would be a bonus)

@Charlie-XIAO Charlie-XIAO mentioned this pull request Jun 28, 2023
Merged
3 tasks
@Charlie-XIAO Charlie-XIAO deleted the cln-no-default branch June 28, 2023 05:39
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@Charlie-XIAO
CLN: use lib.no_default instead of lib.NoDefault in .pivot (pan…
ff919d0 
…das-dev#53877)

* CLN typo lib.NoDefault -> lib.no_default

* also typo in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

CLN: use lib.no_default instead of lib.NoDefault in reshape.pivot
2 participants
@Charlie-XIAO @mroeschke