ENH / CoW: Add lazy copy to eval #53746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Jun 28, 2023
pandas/core/computation/eval.py
Outdated
| target = env.target.copy() | ||
| target = env.target | ||
| if isinstance(target, NDFrame): | ||
| target = target.copy(deep=not using_copy_on_write()) |
There was a problem hiding this comment.
You could also do target.copy(deep=None) here, which will have the same effect (without having to import using_copy_on_write here). I think this is how we did it in most places that had a self.copy() in the method
|
The typing error is related? (don't see it on main, and it happens in the eval.py file, although I don't see how it actually can be related ..) |
|
The ignore didn't seem to have worked .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.