CLN: Remove deprecated numba functions #53455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
Compat
mroeschke
approved these changes
May 30, 2023
Member
|
Thanks @lithomas1 |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
CLN/DEPR: Remove deprecated numba functions
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
CLN/DEPR: Remove deprecated numba functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The replacement for
generated_jitisnumba.extending.overload.That shouldn't be necessary tho IMO.
Since the user function is always part of another jitted numba function, we can just mark the function as
jitableand have it inherit thenopython,nogil, etc. of the outer function.