BUG: dt.round with equal/higher freq resolution would not noop #52841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Non-Nano
phofl
approved these changes
Apr 22, 2023
|
thx @mroeschke |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 22, 2023
…solution would not noop
phofl
pushed a commit
that referenced
this pull request
Apr 22, 2023
…req resolution would not noop) (#52846) Backport PR #52841: BUG: dt.round with equal/higher freq resolution would not noop Co-authored-by: Matthew Roeschke <[email protected]>
| nanos = delta_to_nanoseconds(offset, self._creso) | ||
| if nanos == 0: | ||
| # GH 52761 | ||
| return self |
There was a problem hiding this comment.
should this return a copy?
There was a problem hiding this comment.
Good point. Opened #52982
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
round,ceil,floorreturning incorrect results with Division By Zero warning inpandas-2.0#52761 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.