MAINT: remove from numpy.math cimport usages
#52544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 10, 2023
mroeschke
reviewed
Apr 10, 2023
These are available from Cython's `libc`, which is cleaner. NumPy would like to get rid of shipping libnpymath, and has also deprecated the (unrelated) `numpy.math` in the Python API. So best to not use it from Cython either.
rgommers
force-pushed
the
remove-numpy-math
branch
from
4627d63 to
3926064
Compare
mroeschke
approved these changes
Apr 10, 2023
|
Thanks @rgommers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are available from Cython's
libc, which is cleaner. NumPy would like to get rid of shipping libnpymath, and has also deprecated the (unrelated)numpy.mathin the Python API. So best to not use it from Cython either.