Skip to content

Use date32 for pyarrow date #52332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Use date32 for pyarrow date #52332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76d04a
Use date32 for pyarrow date
alippai Mar 31, 2023
100abfa
Merge branch 'pandas-dev:main' into use-date32
alippai Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/arrays/arrow/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,7 +2015,7 @@ def _dt_second(self):

@property
def _dt_date(self):
return type(self)(self._pa_array.cast(pa.date64()))
return type(self)(self._pa_array.cast(pa.date32()))

@property
def _dt_time(self):
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/extension/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2156,7 +2156,7 @@ def test_dt_properties(prop, expected):
result = getattr(ser.dt, prop)
exp_type = None
if isinstance(expected, date):
exp_type = pa.date64()
exp_type = pa.date32()
elif isinstance(expected, time):
exp_type = pa.time64("ns")
expected = pd.Series(ArrowExtensionArray(pa.array([expected, None], type=exp_type)))
Expand Down