Skip to content

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 8, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This isn't a particularly good solution, but ties into the problem we will have to solve for setitem with a Series anyway so should be good for now.

@phofl phofl added Series Series data structure Copy / view semantics labels Mar 8, 2023
@phofl phofl added this to the 2.0 milestone Mar 8, 2023
@phofl phofl requested a review from jorisvandenbossche March 8, 2023 00:10
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche changed the title CoW: Series.view not respecting CoW BUG / CoW: Series.view not respecting CoW Mar 13, 2023
@jorisvandenbossche jorisvandenbossche merged commit 26b17c2 into pandas-dev:main Mar 13, 2023
@jorisvandenbossche
Copy link
Member

On a separate note, IMO we should also just deprecate this Series.view method: #20251

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 13, 2023
mroeschke pushed a commit that referenced this pull request Mar 13, 2023
…ting CoW) (#51937)

Backport PR #51832: BUG / CoW: Series.view not respecting CoW

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the cow_series_vie branch March 13, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy / view semantics Series Series data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants