Skip to content

BUG: iterparse on read_xml ignores repeated elements #51355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.0.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1304,6 +1304,7 @@ I/O
- Bug in :meth:`DataFrame.to_dict` not converting ``NA`` to ``None`` (:issue:`50795`)
- Bug in :meth:`DataFrame.to_json` where it would segfault when failing to encode a string (:issue:`50307`)
- Bug in :func:`read_xml` where file-like objects failed when iterparse is used (:issue:`50641`)
- Bug in :func:`read_xml` ignored repeated elements when iterparse is used (:issue:`51183`)

Period
^^^^^^
Expand Down
9 changes: 7 additions & 2 deletions pandas/io/xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ def _iterparse_nodes(self, iterparse: Callable) -> list[dict[str, str | None]]:
"local disk and not as compressed files or online sources."
)

iterparse_repeats = len(self.iterparse[row_node]) != len(
set(self.iterparse[row_node])
)

for event, elem in iterparse(self.path_or_buffer, events=("start", "end")):
curr_elem = elem.tag.split("}")[1] if "}" in elem.tag else elem.tag

Expand All @@ -345,12 +349,13 @@ def _iterparse_nodes(self, iterparse: Callable) -> list[dict[str, str | None]]:
row = {}

if row is not None:
if self.names:
if self.names and iterparse_repeats:
for col, nm in zip(self.iterparse[row_node], self.names):
if curr_elem == col:
elem_val = elem.text.strip() if elem.text else None
if row.get(nm) != elem_val and nm not in row:
if elem_val not in row.values() and nm not in row:
row[nm] = elem_val

if col in elem.attrib:
if elem.attrib[col] not in row.values() and nm not in row:
row[nm] = elem.attrib[col]
Expand Down
49 changes: 49 additions & 0 deletions pandas/tests/io/xml/test_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,55 @@ def test_repeat_values_new_names(parser):
tm.assert_frame_equal(df_iter, df_expected)


def test_repeat_elements(parser):
xml = """\
<shapes>
<shape>
<value item="name">circle</value>
<value item="family">ellipse</value>
<value item="degrees">360</value>
<value item="sides">0</value>
</shape>
<shape>
<value item="name">triangle</value>
<value item="family">polygon</value>
<value item="degrees">180</value>
<value item="sides">3</value>
</shape>
<shape>
<value item="name">square</value>
<value item="family">polygon</value>
<value item="degrees">360</value>
<value item="sides">4</value>
</shape>
</shapes>"""
df_xpath = read_xml(
xml,
xpath=".//shape",
parser=parser,
names=["name", "family", "degrees", "sides"],
)

df_iter = read_xml_iterparse(
xml,
parser=parser,
iterparse={"shape": ["value", "value", "value", "value"]},
names=["name", "family", "degrees", "sides"],
)

df_expected = DataFrame(
{
"name": ["circle", "triangle", "square"],
"family": ["ellipse", "polygon", "polygon"],
"degrees": [360, 180, 360],
"sides": [0, 3, 4],
}
)

tm.assert_frame_equal(df_xpath, df_expected)
tm.assert_frame_equal(df_iter, df_expected)


def test_names_option_wrong_length(datapath, parser):
filename = datapath("io", "data", "xml", "books.xml")

Expand Down