Skip to content

BUG: merge_asof with non-nano #50835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

BUG: merge_asof with non-nano #50835

merged 1 commit into from
Jan 23, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel mentioned this pull request Jan 18, 2023
Open
25 tasks
@MarcoGorelli MarcoGorelli self-requested a review January 18, 2023 18:34
@jbrockmendel jbrockmendel added the Non-Nano datetime64/timedelta64 with non-nanosecond resolution label Jan 18, 2023
@mroeschke mroeschke added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Jan 19, 2023
MarcoGorelli
MarcoGorelli approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 23, 2023
@mroeschke mroeschke merged commit 5120720 into pandas-dev:main Jan 23, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-merge branch January 23, 2023 19:49
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
@jbrockmendel @pooja-subramaniam
BUG: merge with non-nano (pandas-dev#50835)
a0367cd
@jorisvandenbossche jorisvandenbossche changed the title BUG: merge with non-nano BUG: merge_asof with non-nano May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

+1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @MarcoGorelli