Skip to content

DOC: Add datetime.tzinfo to paramater tz in tz_localize and tz_convert #50742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Jan 14, 2023

@aqeelat
Copy link

aqeelat commented Jan 14, 2023

Don't forget to add it to the functions listed in the issue. There could be more that I forgot to include.

@luke396
Copy link
Contributor Author

luke396 commented Jan 14, 2023

Don't forget to add it to the functions listed in the issue. There could be more that I forgot to include.

All functions about tz_localize or tz_convert seem to share the same doc template, so this will influence all of them (Series.tz_localize, DataFrame.tz_localize, DateIndex.tz_localize... ). I haven't found more functions that need to be added, so if so, feel free to bring them up.

@aqeelat
Copy link

aqeelat commented Jan 14, 2023

All functions about tz_localize or tz_convert seem to share the same doc template, so this will influence all of them (Series.tz_localize, DataFrame.tz_localize, DateIndex.tz_localize... ). I haven't found more functions that need to be added, so if so, feel free to bring them up.

I actually haven't read the code. Sorry for the wrong comment and thank you for solving the issue.

@mroeschke mroeschke added the Docs label Jan 16, 2023
@mroeschke mroeschke added this to the 2.0 milestone Jan 16, 2023
@mroeschke mroeschke added the Timezones Timezone data dtype label Jan 16, 2023
@mroeschke mroeschke merged commit 89a76f6 into pandas-dev:main Jan 16, 2023
@mroeschke
Copy link
Member

Thanks @luke396

@luke396 luke396 deleted the add-tzinfo-to-paramater-tz-in-tz_convert-tz_localize branch January 17, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: tz_x functions do not include zoneinfo and tzinfo support in their documentation
3 participants