BUG: .max() gives wrong answer for non-nanosecond datetimeindex #50719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
added
Bug
Non-Nano
| @@ -372,7 +372,7 @@ def _wrap_results(result, dtype: np.dtype, fill_value=None): | |||
| if isna(result): | |||
| result = np.datetime64("NaT", "ns") | |||
| else: | |||
| result = np.int64(result).view("datetime64[ns]") | |||
| result = np.int64(result).view(dtype) | |||
There was a problem hiding this comment.
can you do the nat case a couple lines up too just to be on the safe side (like we do for td64 below)
|
thanks - merging then as this is quite simple and unblocks rewriting tests for #50656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Does this need a whatsnew? I wouldn't have thought so, as this wasn't available in 1.5.x