ENH: support any/all for pyarrow numeric and duration dtypes #50717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 19, 2023
pandas/core/arrays/arrow/array.py
Outdated
| zero = Timedelta(0) | ||
| else: | ||
| zero = 0 | ||
| result = (self != zero)._reduce(name, skipna=skipna, **kwargs) |
There was a problem hiding this comment.
Could we use data = pc.not_equal(self._data, zero) and continue with the logic below?
mroeschke
reviewed
Jan 19, 2023
pandas/core/arrays/arrow/array.py
Outdated
| else: | ||
| zero = 0 | ||
|
|
||
| not_eq = pc.not_equal(self._data, zero) |
There was a problem hiding this comment.
Ah sorry, I had meant
if name in ...:
...
data = pc.not_equal(self._data, zero)
else:
data = self._data
....
try:
result = pyarrow_method(data...)
|
updated per requests + green |
mroeschke
approved these changes
Jan 24, 2023
|
Thanks @jbrockmendel |
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
…dev#50717) * ENH: support any/all for pyarrow numeric and duration dtypes * mypy fixup * use pc.not_equal * use suggested pattern * fix not_eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Cuts the runtime for
pytest pandas/tests/extension/test_arrow.py::TestBaseBooleanReduce::test_reduce_seriesfrom 39.8s to 2.3s.