add test to check crosstab supports Float64 formats #50459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 28, 2022
| df = DataFrame( | ||
| {"A": [1, 2, 2, 1], "B": [3, 3, 4, 5], "C": [-1.0, 10.0, 1.0, 10.0]} | ||
| ) | ||
| df = df.astype({"C": "Float64"}) |
There was a problem hiding this comment.
Can you avoid the astype and define this as float immediately?
phofl
reviewed
Dec 28, 2022
| index=[1, 2, "All"], | ||
| dtype="Float64", | ||
| ) | ||
| expected.columns = Index([3, 4, 5, "All"], dtype="object", name="B") |
There was a problem hiding this comment.
Same here, please define expected in one go
There was a problem hiding this comment.
Thank you, @phofl, for your comments. I updated my PR as you suggested.
phofl
approved these changes
Dec 28, 2022
|
thx @natmokval |
|
Thank you, @phofl, for reviewing my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new test is added. The test validates
crosstabbehavior withFloat64. I have checked that the problem occurs whenFloat64is used together withmargins=True.The test fails on
1.5.2and passes onmain.