Skip to content

ENH: Add use_nullable_dtypes to read_sql_query and table #50247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2022
Merged

ENH: Add use_nullable_dtypes to read_sql_query and table #50247

merged 5 commits into from
Dec 18, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 13, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added IO SQL to_sql, read_sql, read_sql_query NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Dec 13, 2022
mroeschke
mroeschke reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict otherwise LGTM

@phofl
Merge remote-tracking branch 'upstream/main' into sql
b2f6700 
# Conflicts:
#	pandas/tests/io/test_sql.py
@phofl phofl merged commit d0dbd9f into pandas-dev:main Dec 18, 2022
@phofl phofl added this to the 2.0 milestone Dec 18, 2022
@phofl phofl deleted the sql_nullable branch December 18, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke