Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Dec 13, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added IO SQL to_sql, read_sql, read_sql_query NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Dec 13, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict otherwise LGTM

# Conflicts:
#	pandas/tests/io/test_sql.py
@phofl phofl merged commit d0dbd9f into pandas-dev:main Dec 18, 2022
@phofl phofl added this to the 2.0 milestone Dec 18, 2022
@phofl phofl deleted the sql_nullable branch December 18, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO SQL to_sql, read_sql, read_sql_query NA - MaskedArrays Related to pd.NA and nullable extension arrays

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants