Skip to content

Conversation

Idilismiguzel
Copy link
Contributor

The first issue in the link: noatamir/pyladies-berlin-sprints#4

@Idilismiguzel
Copy link
Contributor Author

@noatamir, @phofl @mroeschke

@mroeschke mroeschke added Docs IO CSV read_csv, to_csv NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Dec 1, 2022
@phofl phofl changed the title add example for read_csv with nullable dtype DOC: Add example for read_csv with nullable dtype Dec 1, 2022
@phofl phofl added the Sprints Sprint Pull Requests label Dec 1, 2022
os.remove("foo.csv")
.. ipython:: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a small comment before the python block like:

Setting use_nullable_dtypes=True will result in nullable dtypes for every column.

Between line 465 and 467

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

@mroeschke mroeschke added this to the 2.0 milestone Dec 1, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good to me given the CI checks pass

@WillAyd WillAyd merged commit 7f47d33 into pandas-dev:main Dec 2, 2022
@WillAyd
Copy link
Member

WillAyd commented Dec 2, 2022

Thanks @Idilismiguzel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv NA - MaskedArrays Related to pd.NA and nullable extension arrays Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants