STYLE: #49656 - generic.py #49960
Merged
STYLE: #49656 - generic.py #49960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Nov 29, 2022
pandas/core/generic.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| import collections | |||
| import datetime as dt | |||
| import gc | |||
| import json | |||
| import json as js | |||
There was a problem hiding this comment.
this is non-standard and not obvious - does it work to just import the functions from json, so from json import loads, jumps and then use those directly?
There was a problem hiding this comment.
I have changed it based on your request
pandas/core/generic.py
Outdated
| missing, | ||
| missing as miss, |
There was a problem hiding this comment.
does it work to just directly import the methods you need from pandas.core.missing?
There was a problem hiding this comment.
I have changed it based on your request
MarcoGorelli
suggested changes
Nov 29, 2022
There was a problem hiding this comment.
thanks @bang128 - can you run the pre-commit checks too please? check the contributing guide for how
MarcoGorelli
approved these changes
Nov 29, 2022
|
@MarcoGorelli I am very glad to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.