PERF: Fix performance regression for isin with mismatching dtypes #49162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
|
LGTM pending green |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 18, 2022
…in with mismatching dtypes
phofl
added a commit
that referenced
this pull request
Oct 18, 2022
…for isin with mismatching dtypes) (#49165) Backport PR #49162: PERF: Fix performance regression for isin with mismatching dtypes Co-authored-by: Patrick Hoefler <[email protected]>
5 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
|
@phofl - this may have induced a performance regression, please have a look and open an issue if necessary. This is a semi-automated message. |
|
@rhshadrach the diagram is empty, is this expected? |
|
Hmm, it seems GitHub does not like me ending a URL with a single quote. I've edited the comment above, and will be updating my script 😄 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.From the asv run you did. This restores 1.4.0 performance. The cast to object avoided the fast path we hit before
cc @jbrockmendel
Not a blocker for 1.5.1, will move whatsnew if it is released before