Skip to content

solved the pylint issue of "no self argument" #48912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2022
Merged

solved the pylint issue of "no self argument" #48912

merged 2 commits into from
Oct 2, 2022

Conversation

Exoutia
Copy link
Contributor

@Exoutia Exoutia commented Oct 2, 2022

Issue number: #48855

@MarcoGorelli MarcoGorelli self-requested a review October 2, 2022 08:55
MarcoGorelli
MarcoGorelli suggested changes Oct 2, 2022
View reviewed changes
@Exoutia @MarcoGorelli
Update pandas/tests/io/test_sql.py
9911c3e 
Co-authored-by: Marco Edward Gorelli <[email protected]>
MarcoGorelli
MarcoGorelli approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending green

@Exoutia
Copy link
Contributor Author

Exoutia commented Oct 2, 2022

Looks good to me pending green

68747470733a2f2f692e666c756666792e63632f344872646d4777374d484c33726348334a306c434242473778686c786e5773372e676966

🤣🤣Loved the cat 😺😺

@MarcoGorelli MarcoGorelli added this to the 1.6 milestone Oct 2, 2022
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Oct 2, 2022
@twoertwein twoertwein merged commit cfeed03 into pandas-dev:main Oct 2, 2022
@twoertwein
Copy link
Member

Thanks @Exoutia!

@slackline slackline mentioned this pull request Oct 9, 2022
Closed
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@Exoutia @MarcoGorelli @noatamir
solved the pylint issue of "no self argument" (pandas-dev#48912)
852dc6b 
* solved the pylint issue of  "no self argument"

* Update pandas/tests/io/test_sql.py

Co-authored-by: Marco Edward Gorelli <[email protected]>

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Exoutia @twoertwein @MarcoGorelli @mroeschke