BUG: Fix read_xml raising syntax error when reading XML with Chinese tags #47905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Aug 1, 2022
|
Thanks for the quick fix @ParfaitG |
This comment was marked as resolved.
This comment was marked as resolved.
|
@ParfaitG mind applying the backport PR with the instructions above if you have the time? |
ParfaitG
added a commit
to ParfaitG/pandas
that referenced
this pull request
Aug 1, 2022
…when reading XML with Chinese tags
4 tasks
ParfaitG
added a commit
to ParfaitG/pandas
that referenced
this pull request
Aug 2, 2022
…when reading XML with Chinese tags
ParfaitG
added a commit
to ParfaitG/pandas
that referenced
this pull request
Aug 2, 2022
…when reading XML with Chinese tags
|
@mroeschke it's a bit late in the release cycle for bug fixes. Is this considered low risk? and 1.5 is may be not far anyway. |
|
#47925 (comment) mentions I think it's okay pushing to 1.5 instead |
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Aug 8, 2022
simonjayhawkins
added a commit
that referenced
this pull request
Aug 8, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.4.4.rstfile if fixing a bug or adding a new feature.