TYP: generate_regular_range #47295
Merged
TYP: generate_regular_range #47295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jun 9, 2022
| @@ -11,13 +11,15 @@ | |||
| [ | |||
| # exclude tests | |||
| "pandas/tests", | |||
| # exclude vendored files | |||
| "pandas/io/clipboard", | |||
| "pandas/util/version", | |||
mroeschke
reviewed
Jun 9, 2022
| periods: int, | ||
| start: Timestamp | Timedelta | None, | ||
| end: Timestamp | Timedelta | None, | ||
| periods: int | None, |
There was a problem hiding this comment.
Nit: Mind updating the docstring below for this argument that periods can be None?
There was a problem hiding this comment.
green and updated the doc-string
mroeschke
approved these changes
Jun 10, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: generate_regular_range * update doc-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_regular_rangeseems to be only called from un-annotated places: mypy doesn't know that start/end/periods can actually be None.edit:
I'm not annotating the functions calling
generate_regular_rangein this PR as my aim with this PR is to simply makepandas/core/arrays/_ranges.pycompatible with pyright.