Skip to content

ENH: Move NumExprClobberingError to error/__init__.py per GH27656 #47253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2022
Merged

ENH: Move NumExprClobberingError to error/__init__.py per GH27656 #47253

merged 3 commits into from
Jun 7, 2022

Conversation

dataxerik
Copy link
Contributor

@mroeschke
Copy link
Member

Looks like there are docbuild failures

2022-06-06T02:29:12.9065297Z /home/runner/work/pandas/pandas/doc/source/reference/testing.rst:64:<autosummary>:1: WARNING: Inline interpreted text or phrase reference start-string without end-string.
2022-06-06T02:29:12.9067287Z /home/runner/work/pandas/pandas/pandas/errors/__init__.py:docstring of pandas.errors.NumExprClobberingError:2: WARNING: Inline interpreted text or phrase reference start-string without end-string.

@mroeschke mroeschke added Enhancement Error Reporting Incorrect or improved errors from pandas labels Jun 6, 2022
@dataxerik
Copy link
Contributor Author

Looks like there are docbuild failures

2022-06-06T02:29:12.9065297Z /home/runner/work/pandas/pandas/doc/source/reference/testing.rst:64:<autosummary>:1: WARNING: Inline interpreted text or phrase reference start-string without end-string.
2022-06-06T02:29:12.9067287Z /home/runner/work/pandas/pandas/pandas/errors/__init__.py:docstring of pandas.errors.NumExprClobberingError:2: WARNING: Inline interpreted text or phrase reference start-string without end-string.

Ah yeah, my bad, illegal use of bad tick lol. I've fixed it. Thank you for the feedback

@mroeschke mroeschke added this to the 1.5 milestone Jun 7, 2022
mroeschke
mroeschke reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a merge conflict otherwise LGTM

@mroeschke mroeschke merged commit c3ac531 into pandas-dev:main Jun 7, 2022
@mroeschke
Copy link
Member

Making great progress on that issue, thanks again!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@dataxerik @yehoshuadimarsky
ENH: Move NumExprClobberingError to error/__init__.py per GH27656 (pa…
1c3f3a7 
…ndas-dev#47253)

* ENH: Move NumExprClobberingError to error/__init__.py per GH27656

* ENH: change backtick to single quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Enhancement Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@dataxerik @mroeschke