Skip to content

Fix typo in tz_convert docs #47131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

Fix typo in tz_convert docs #47131

merged 1 commit into from
May 26, 2022

Conversation

jackgoldsmith4
Copy link
Contributor

@jackgoldsmith4 jackgoldsmith4 commented May 26, 2022 •
edited
Loading

mroeschke
mroeschke requested changes May 26, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only needed change is to decorate tz_convert with @doc(klass=_shared_doc_kwargs["klass"])

@jackgoldsmith4 jackgoldsmith4 requested a review from mroeschke May 26, 2022 20:14
@mroeschke mroeschke added Docs Timezones Timezone data dtype labels May 26, 2022
@mroeschke mroeschke added this to the 1.5 milestone May 26, 2022
mroeschke
mroeschke approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (and thanks for fixing tz_localize as well)

@mroeschke mroeschke merged commit 8e522eb into pandas-dev:main May 26, 2022
@jackgoldsmith4 jackgoldsmith4 deleted the tz-convert-docs branch May 26, 2022 21:26
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jackgoldsmith4 @yehoshuadimarsky
Fix typo in tz_convert docs (pandas-dev#47131)
9013134 
add klass doc decorations to tz_convert and tz_localize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs Timezones Timezone data dtype
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

DOC: tz_convert docs could be improved for Series and DataFrame
2 participants
@jackgoldsmith4 @mroeschke