Skip to content

CLN: Remove special case for rank in groupby.ops #46953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022
Merged

CLN: Remove special case for rank in groupby.ops #46953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a832f
CLN: Remove special case for rank in groupby.ops
rhshadrach May 6, 2022
68ee19f
Remove TODO
rhshadrach May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/_libs/groupby.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,8 +1325,9 @@ def group_rank(
mask=sub_mask,
)
for i in range(len(result)):
# TODO: why can't we do out[:, k] = result?
out[i, k] = result[i]
if labels[i] >= 0:
# TODO: why can't we do out[:, k] = result?
out[i, k] = result[i]


# ----------------------------------------------------------------------
Expand Down
4 changes: 0 additions & 4 deletions pandas/core/groupby/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,10 +623,6 @@ def _call_cython_op(

result = result.T

if self.how == "rank" and self.has_dropped_na:
# TODO: Wouldn't need this if group_rank supported mask
result = np.where(comp_ids < 0, np.nan, result)

if self.how not in self.cast_blocklist:
# e.g. if we are int64 and need to restore to datetime64/timedelta64
# "rank" is the only member of cast_blocklist we get here
Expand Down